Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add explicit requirement of ActiveSupport::Inflector. Fixes #386 #387

Merged
merged 1 commit into from
Nov 5, 2020
Merged

Add explicit requirement of ActiveSupport::Inflector. Fixes #386 #387

merged 1 commit into from
Nov 5, 2020

Conversation

rdvdijk
Copy link
Contributor

@rdvdijk rdvdijk commented Nov 5, 2020

This adds an explicit requirement of ActiveSupport::Inflector, which solves #386.

Using this Gemfile:

source "https://rubygems.org"
gem "activerecord"
gem "acts_as_list"

The following will now work:

bundle install
bundle console # would fail previously

@brendon brendon merged commit 1bddf8b into brendon:master Nov 5, 2020
@brendon
Copy link
Owner

brendon commented Nov 5, 2020

Perfect! 👍 Would you like a release or are you happy to work with master for now?

@rdvdijk
Copy link
Contributor Author

rdvdijk commented Nov 6, 2020

I don't need a release, this can wait. But thanks!

@rdvdijk rdvdijk deleted the require-active-support-inflector branch November 6, 2020 10:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rdvdijk @brendon